For those who are unfamiliar with it, the Code Review Stack Exchange site deals with reviewing working code for feedback on
- Best practices and design pattern usage
- Security issues
- Performance
- Correctness in unanticipated cases
It even has a few vimscript questions. Note that code review answers shouldn't be just blocks of code that improve upon the code in question, but should explain how the code can be improved.
Now, to the point of my question. I've been thinking of splitting of parts of my vim configuration into plugins, both for modularity and so that others can use it more easily. Even though I have a lot of rep on this site, I'm nowhere near a Vim expert. A lot of my config (what little there is) might be (and probably is) terrible in the following respects:
- readability (and consequently, maintainability)
- efficiency or performance
- correctness (for security and corner cases)
It might look like this, without being as good:
So, I would like to post code (either in self-contained parts, or the whole script) for review here.
How do you feel about this? Will it fit here? Should I stick to Code Review instead?
Related, but orthogonal is Are vimgolf questions on-topic?
Shorter code is not necessarily better code.
Note
This is strictly for working code, distinguishing it from debugging problems. The posted code should reasonably work as intended to the best of my knowledge, however, what might be a common case for you could have escaped my notice.